ViewVC Help
View File | Revision Log | Show Annotations | Download File | View Changeset | Root Listing
root/public/ibx/trunk/runtime/IBDatabase.pas
(Generate patch)

Comparing ibx/trunk/runtime/IBDatabase.pas (file contents):
Revision 33 by tony, Sat Jul 18 12:30:52 2015 UTC vs.
Revision 45 by tony, Tue Dec 6 10:33:46 2016 UTC

# Line 35 | Line 35 | unit IBDatabase;
35  
36   {$Mode Delphi}
37  
38 + {$codepage UTF8}
39 +
40   interface
41  
42   uses
# Line 43 | Line 45 | uses
45   {$ELSE}
46    unix,
47   {$ENDIF}
48 <  SysUtils, Classes, FPTimer, IBHeader, IBExternals, DB,
47 <  IB, CustApp;
48 >  SysUtils, Classes, FPTimer, IBExternals, DB, IB, CustApp, IBTypes;
49  
50   const
51    DPBPrefix = 'isc_dpb_';
# Line 115 | Line 116 | const
116      'set_db_readonly',
117      'set_db_sql_dialect',
118      'gfix_attach',
119 <    'gstat_attach'
119 >    'gstat_attach',
120 >    'set_db_charset',
121 >    'gsec_attach',
122 >    'address_path' ,
123 >    'process_id',
124 >    'no_db_triggers',
125 >    'trusted_auth',
126 >    'process_name',
127 >    'trusted_role',
128 >    'org_filename',
129 >    'utf8_ilename',
130 >    'ext_call_depth'
131    );
132  
133    TPBPrefix = 'isc_tpb_';
# Line 139 | Line 151 | const
151      'rec_version',
152      'no_rec_version',
153      'restart_requests',
154 <    'no_auto_undo'
154 >    'no_auto_undo',
155 >    'lock_timeout'
156    );
157  
158   type
# Line 155 | Line 168 | type
168    { TIBDatabase }
169    TIBDataBase = class(TCustomConnection)
170    private
171 +    FAttachment: IAttachment;
172 +    FCreateDatabase: boolean;
173 +    FCreateIfNotExists: boolean;
174 +    FDefaultCharSetID: integer;
175 +    FDefaultCharSetName: RawByteString;
176 +    FDefaultCodePage: TSystemCodePage;
177 +    FDPB: IDPB;
178      FAllowStreamedConnected: boolean;
179      FHiddenPassword: string;
180 <    FIBLoaded: Boolean;
180 >    FOnCreateDatabase: TNotifyEvent;
181      FOnLogin: TIBDatabaseLoginEvent;
182      FSQLHourGlass: Boolean;
183      FTraceFlags: TTraceFlags;
184      FDBSQLDialect: Integer;
185      FSQLDialect: Integer;
186      FOnDialectDowngradeWarning: TNotifyEvent;
167    FCanTimeout: Boolean;
187      FSQLObjects: TList;
188      FTransactions: TList;
189      FDBName: TIBFileName;
190      FDBParams: TStrings;
191      FDBParamsChanged: Boolean;
173    FDPB: PChar;
174    FDPBLength: Short;
175    FHandle: TISC_DB_HANDLE;
176    FHandleIsShared: Boolean;
192      FOnIdleTimer: TNotifyEvent;
193      FDefaultTransaction: TIBTransaction;
194      FInternalTransaction: TIBTransaction;
180    FStreamedConnected: Boolean;
195      FTimer: TFPTimer;
196      FUserNames: TStringList;
197      FDataSets: TList;
198      FLoginCalled: boolean;
199 <    FCharSetSizes: array of integer;
199 >    FUseDefaultSystemCodePage: boolean;
200      procedure EnsureInactive;
201      function GetDBSQLDialect: Integer;
202      function GetSQLDialect: Integer;
# Line 192 | Line 206 | type
206      procedure DBParamsChanging(Sender: TObject);
207      function GetSQLObject(Index: Integer): TIBBase;
208      function GetSQLObjectCount: Integer;
195    function GetDBParamByDPB(const Idx: Integer): String;
209      function GetIdleTimer: Integer;
210      function GetTransaction(Index: Integer): TIBTransaction;
211      function GetTransactionCount: Integer;
212 <    function Login: Boolean;
200 <    procedure LoadCharSetInfo;
212 >    function Login(var aDatabaseName: string): Boolean;
213      procedure SetDatabaseName(const Value: TIBFileName);
214      procedure SetDBParamByDPB(const Idx: Integer; Value: String);
215      procedure SetDBParams(Value: TStrings);
# Line 236 | Line 248 | type
248      function IndexOfDBConst(st: String): Integer;
249      function TestConnected: Boolean;
250      procedure CheckDatabaseName;
239    function Call(ErrCode: ISC_STATUS; RaiseError: Boolean): ISC_STATUS;
251      function AddTransaction(TR: TIBTransaction): Integer;
252      function FindTransaction(TR: TIBTransaction): Integer;
253      function FindDefaultTransaction(): TIBTransaction;
254      procedure RemoveTransaction(Idx: Integer);
255      procedure RemoveTransactions;
245    procedure SetHandle(Value: TISC_DB_HANDLE);
256  
257 <    property Handle: TISC_DB_HANDLE read FHandle;
257 >    property Attachment: IAttachment read FAttachment;
258 >    property DBSQLDialect : Integer read FDBSQLDialect;
259      property IsReadOnly: Boolean read GetIsReadOnly;
249    property DBParamByDPB[const Idx: Integer]: String read GetDBParamByDPB
250                                                      write SetDBParamByDPB;
260      property SQLObjectCount: Integer read GetSQLObjectCount;
261      property SQLObjects[Index: Integer]: TIBBase read GetSQLObject;
253    property HandleIsShared: Boolean read FHandleIsShared;
262      property TransactionCount: Integer read GetTransactionCount;
263      property Transactions[Index: Integer]: TIBTransaction read GetTransaction;
264      property InternalTransaction: TIBTransaction read FInternalTransaction;
265 +    property DefaultCharSetName: RawByteString read FDefaultCharSetName;
266 +    property DefaultCharSetID: integer read FDefaultCharSetID;
267 +    property DefaultCodePage: TSystemCodePage read FDefaultCodePage;
268  
269    published
270      property Connected;
271 +    property CreateIfNotExists: boolean read FCreateIfNotExists write FCreateIfNotExists;
272      property AllowStreamedConnected: boolean read FAllowStreamedConnected
273               write FAllowStreamedConnected;
274      property DatabaseName: TIBFileName read FDBName write SetDatabaseName;
# Line 267 | Line 279 | type
279      property IdleTimer: Integer read GetIdleTimer write SetIdleTimer;
280      property SQLDialect : Integer read GetSQLDialect write SetSQLDialect default 3;
281      property SQLHourGlass: Boolean read FSQLHourGlass write FSQLHourGlass default true;
270    property DBSQLDialect : Integer read FDBSQLDialect;
282      property TraceFlags: TTraceFlags read FTraceFlags write FTraceFlags;
283 +    property UseDefaultSystemCodePage: boolean read FUseDefaultSystemCodePage
284 +                                               write FUseDefaultSystemCodePage;
285      property AfterConnect;
286      property AfterDisconnect;
287      property BeforeConnect;
288      property BeforeDisconnect;
289 +    property OnCreateDatabase: TNotifyEvent read FOnCreateDatabase write FOnCreateDatabase;
290      property OnLogin: TIBDatabaseLoginEvent read FOnLogin write FOnLogin;
291      property OnIdleTimer: TNotifyEvent read FOnIdleTimer write FOnIdleTimer;
292      property OnDialectDowngradeWarning: TNotifyEvent read FOnDialectDowngradeWarning write FOnDialectDowngradeWarning;
293    end;
294  
295 <  { TIBTransaction }
295 >  TDefaultEndAction = TARollback..TACommit;
296  
297 <  TTransactionAction         = (TARollback, TACommit, TARollbackRetaining, TACommitRetaining);
297 >  { TIBTransaction }
298  
299    TIBTransaction = class(TComponent)
300    private
301 +    FTransactionIntf: ITransaction;
302      FAfterDelete: TNotifyEvent;
303      FAfterEdit: TNotifyEvent;
304      FAfterExecQuery: TNotifyEvent;
# Line 291 | Line 306 | type
306      FAfterPost: TNotifyEvent;
307      FAfterTransactionEnd: TNotifyEvent;
308      FBeforeTransactionEnd: TNotifyEvent;
294    FIBLoaded: Boolean;
295    FCanTimeout         : Boolean;
309      FDatabases          : TList;
310      FOnStartTransaction: TNotifyEvent;
311      FSQLObjects         : TList;
312      FDefaultDatabase    : TIBDatabase;
300    FHandle             : TISC_TR_HANDLE;
301    FHandleIsShared     : Boolean;
313      FOnIdleTimer          : TNotifyEvent;
314      FStreamedActive     : Boolean;
315 <    FTPB                : PChar;
305 <    FTPBLength          : Short;
315 >    FTPB                : ITPB;
316      FTimer              : TFPTimer;
317 <    FDefaultAction      : TTransactionAction;
317 >    FDefaultAction      : TDefaultEndAction;
318      FTRParams           : TStrings;
319      FTRParamsChanged    : Boolean;
320      FInEndTransaction   : boolean;
# Line 327 | Line 337 | type
337      function GetIdleTimer: Integer;
338      procedure BeforeDatabaseDisconnect(DB: TIBDatabase);
339      procedure SetActive(Value: Boolean);
330    procedure SetDefaultAction(Value: TTransactionAction);
340      procedure SetDefaultDatabase(Value: TIBDatabase);
341      procedure SetIdleTimer(Value: Integer);
342      procedure SetTRParams(Value: TStrings);
# Line 340 | Line 349 | type
349  
350    protected
351      procedure Loaded; override;
343    procedure SetHandle(Value: TISC_TR_HANDLE);
352      procedure Notification( AComponent: TComponent; Operation: TOperation); override;
353  
354    public
355      constructor Create(AOwner: TComponent); override;
356      destructor Destroy; override;
349    function Call(ErrCode: ISC_STATUS; RaiseError: Boolean): ISC_STATUS;
357      procedure Commit;
358      procedure CommitRetaining;
359      procedure Rollback;
# Line 367 | Line 374 | type
374      property Databases[Index: Integer]: TIBDatabase read GetDatabase;
375      property SQLObjectCount: Integer read GetSQLObjectCount;
376      property SQLObjects[Index: Integer]: TIBBase read GetSQLObject;
370    property Handle: TISC_TR_HANDLE read FHandle;
371    property HandleIsShared: Boolean read FHandleIsShared;
377      property InTransaction: Boolean read GetInTransaction;
378 <    property TPB: PChar read FTPB;
379 <    property TPBLength: Short read FTPBLength;
378 >    property TransactionIntf: ITransaction read FTransactionIntf;
379 >    property TPB: ITPB read FTPB;
380    published
381      property Active: Boolean read GetInTransaction write SetActive;
382      property DefaultDatabase: TIBDatabase read FDefaultDatabase
383                                             write SetDefaultDatabase;
384      property IdleTimer: Integer read GetIdleTimer write SetIdleTimer default 0;
385 <    property DefaultAction: TTransactionAction read FDefaultAction write SetDefaultAction default taCommit;
385 >    property DefaultAction: TDefaultEndAction read FDefaultAction write FDefaultAction default taCommit;
386      property Params: TStrings read FTRParams write SetTRParams;
387      property OnIdleTimer: TNotifyEvent read FOnIdleTimer write FOnIdleTimer;
388      property BeforeTransactionEnd: TNotifyEvent read FBeforeTransactionEnd
# Line 428 | Line 433 | type
433      procedure DoBeforeTransactionEnd(Action: TTransactionAction); virtual;
434      procedure DoAfterTransactionEnd; virtual;
435      procedure DoTransactionFree; virtual;
431    function GetDBHandle: PISC_DB_HANDLE; virtual;
432    function GetTRHandle: PISC_TR_HANDLE; virtual;
436      procedure SetDatabase(Value: TIBDatabase); virtual;
437      procedure SetTransaction(Value: TIBTransaction); virtual;
438    public
# Line 442 | Line 445 | type
445      procedure DoAfterDelete(Sender: TObject); virtual;
446      procedure DoAfterInsert(Sender: TObject); virtual;
447      procedure DoAfterPost(Sender: TObject); virtual;
445    function GetCharSetSize(CharSetID: integer): integer;
448      procedure HandleException(Sender: TObject);
449      procedure SetCursor;
450      procedure RestoreCursor;
# Line 461 | Line 463 | type
463      property OnTransactionFree: TNotifyEvent read FOnTransactionFree write FOnTransactionFree;
464      property Database: TIBDatabase read FDatabase
465                                      write SetDatabase;
464    property DBHandle: PISC_DB_HANDLE read GetDBHandle;
466      property Owner: TObject read FOwner;
466    property TRHandle: PISC_TR_HANDLE read GetTRHandle;
467      property Transaction: TIBTransaction read FTransaction
468                                            write SetTransaction;
469    end;
470  
471 < procedure GenerateDPB(sl: TStrings; var DPB: string; var DPBLength: Short);
472 < procedure GenerateTPB(sl: TStrings; var TPB: string; var TPBLength: Short);
471 > function GenerateDPB(sl: TStrings): IDPB;
472 > function GenerateTPB(sl: TStrings): ITPB;
473  
474  
475   implementation
476  
477 < uses IBIntf, IBSQLMonitor, IBCustomDataSet, IBDatabaseInfo, IBSQL, IBUtils,
478 <     typInfo;
477 > uses  IBSQLMonitor, IBCustomDataSet, IBDatabaseInfo, IBSQL, IBUtils,
478 >     typInfo, FBMessages, IBErrorCodes;
479  
480   { TIBDatabase }
481  
482 < constructor TIBDataBase.Create(AOwner: TComponent);
483 < {$ifdef WINDOWS}
484 < var acp: uint;
485 < {$endif}
482 > constructor TIBDataBase.Create(AOwner: TComponent);
483   begin
484    inherited Create(AOwner);
488  FIBLoaded := False;
489  CheckIBLoaded;
490  FIBLoaded := True;
485    LoginPrompt := True;
486    FSQLObjects := TList.Create;
487    FTransactions := TList.Create;
# Line 498 | Line 492 | begin
492       (AOwner is TCustomApplication) and
493       TCustomApplication(AOWner).ConsoleApplication then
494      LoginPrompt := false;
501  {$ifdef UNIX}
502  if csDesigning in ComponentState then
503    FDBParams.Add('lc_ctype=UTF8');
504  {$else}
505  {$ifdef WINDOWS}
506  if csDesigning in ComponentState then
507  begin
508    acp := GetACP;
509    if (acp >= 1250) and (acp <= 1254) then
510      FDBParams.Values['lc_ctype'] := Format('WIN%d',[acp]);
511  end;
512  {$endif}
513  {$endif}
495    FDBParamsChanged := True;
496    TStringList(FDBParams).OnChange := DBParamsChange;
497    TStringList(FDBParams).OnChanging := DBParamsChanging;
498    FDPB := nil;
518  FHandle := nil;
499    FUserNames := nil;
500    FInternalTransaction := TIBTransaction.Create(self);
501    FInternalTransaction.DefaultDatabase := Self;
# Line 530 | Line 510 | begin
510    CheckStreamConnect;
511   end;
512  
513 < destructor TIBDataBase.Destroy;
513 > destructor TIBDataBase.Destroy;
514   var
515    i: Integer;
516   begin
517 <  if FIBLoaded then
518 <  begin
519 <    IdleTimer := 0;
520 <    if FHandle <> nil then
521 <      ForceClose;
522 <    for i := 0 to FSQLObjects.Count - 1 do
523 <      if FSQLObjects[i] <> nil then
524 <        SQLObjects[i].DoDatabaseFree;
525 <    RemoveSQLObjects;
526 <    RemoveTransactions;
527 <    FInternalTransaction.Free;
528 <    FreeMem(FDPB);
529 <    FDPB := nil;
530 <    FDBParams.Free;
551 <    FSQLObjects.Free;
552 <    FUserNames.Free;
553 <    FTransactions.Free;
554 <  end;
517 >  IdleTimer := 0;
518 >  if FAttachment <> nil then
519 >    ForceClose;
520 >  for i := 0 to FSQLObjects.Count - 1 do
521 >    if FSQLObjects[i] <> nil then
522 >      SQLObjects[i].DoDatabaseFree;
523 >  RemoveSQLObjects;
524 >  RemoveTransactions;
525 >  FInternalTransaction.Free;
526 >  FDPB := nil;
527 >  FDBParams.Free;
528 >  FSQLObjects.Free;
529 >  FUserNames.Free;
530 >  FTransactions.Free;
531    FDataSets.Free;
532    inherited Destroy;
533   end;
534  
559 function TIBDataBase.Call(ErrCode: ISC_STATUS; RaiseError: Boolean
560   ): ISC_STATUS;
561 begin
562  result := ErrCode;
563  FCanTimeout := False;
564  if RaiseError and (ErrCode > 0) then
565    IBDataBaseError;
566 end;
567
535   procedure TIBDataBase.CheckActive;
536   begin
537    if StreamedConnected and (not Connected) then
538      Loaded;
539 <  if FHandle = nil then
539 >  if FAttachment = nil then
540      IBError(ibxeDatabaseClosed, [nil]);
541   end;
542  
# Line 577 | Line 544 | end;
544   begin
545    if csDesigning in ComponentState then
546    begin
547 <    if FHandle <> nil then
547 >    if FAttachment <> nil then
548        Close;
549    end
550   end;
551  
552   procedure TIBDataBase.CheckInactive;
553   begin
554 <  if FHandle <> nil then
554 >  if FAttachment <> nil then
555      IBError(ibxeDatabaseOpen, [nil]);
556   end;
557  
558   procedure TIBDataBase.CheckDatabaseName;
559   begin
560 <  if (FDBName = '') then
560 >  if (Trim(FDBName) = '') then
561      IBError(ibxeDatabaseNameMissing, [nil]);
562   end;
563  
# Line 629 | Line 596 | begin
596    if Connected then
597      InternalClose(False);
598    FDBSQLDialect := 1;
599 <  SetLength(FCharSetSizes,0);
599 >  FDefaultCharSetName := '';
600 >  FDefaultCharSetID := 0;
601 >  FDefaultCodePage := CP_NONE;
602   end;
603  
604 < procedure TIBDataBase.CreateDatabase;
636 < var
637 <  tr_handle: TISC_TR_HANDLE;
604 >  procedure TIBDataBase.CreateDatabase;
605   begin
606    CheckInactive;
607 <  tr_handle := nil;
608 <  Call(
609 <    isc_dsql_execute_immediate(StatusVector, @FHandle, @tr_handle, 0,
643 <                               PChar('CREATE DATABASE ''' + FDBName + ''' ' + {do not localize}
644 <                               Params.Text), SQLDialect, nil),
645 <    True);
607 >  CheckDatabaseName;
608 >  FCreateDatabase := true;
609 >  Connected := true;
610   end;
611  
612   procedure TIBDataBase.DropDatabase;
613   begin
614    CheckActive;
615 <  Call(isc_drop_database(StatusVector, @FHandle), True);
615 >  FAttachment.DropDatabase;
616 >  FAttachment := nil;
617   end;
618  
619   procedure TIBDataBase.DBParamsChange(Sender: TObject);
# Line 701 | Line 666 | end;
666  
667   function TIBDataBase.GetConnected: Boolean;
668   begin
669 <  result := FHandle <> nil;
669 >  result := (FAttachment <> nil) and FAttachment.IsConnected;
670   end;
671  
672   function TIBDataBase.GetSQLObject(Index: Integer): TIBBase;
# Line 718 | Line 683 | begin
683      Inc(result);
684   end;
685  
686 < function TIBDataBase.GetDBParamByDPB( const Idx: Integer): String;
722 < var
723 <  ConstIdx, EqualsIdx: Integer;
724 < begin
725 <  if (Idx > 0) and (Idx <= isc_dpb_last_dpb_constant) then
726 <  begin
727 <    ConstIdx := IndexOfDBConst(DPBConstantNames[Idx]);
728 <    if ConstIdx = -1 then
729 <      result := ''
730 <    else
731 <    begin
732 <      result := Params[ConstIdx];
733 <      EqualsIdx := Pos('=', result); {mbcs ok}
734 <      if EqualsIdx = 0 then
735 <        result := ''
736 <      else
737 <        result := Copy(result, EqualsIdx + 1, Length(result));
738 <    end;
739 <  end
740 <  else
741 <    result := '';
742 < end;
743 <
744 < function TIBDataBase.GetIdleTimer: Integer;
686 > function TIBDataBase.GetIdleTimer: Integer;
687   begin
688    result := FTimer.Interval;
689   end;
# Line 806 | Line 748 | begin
748      end;
749    end;
750  
751 <  if (not HandleIsShared) and
752 <     (Call(isc_detach_database(StatusVector, @FHandle), False) > 0) and
811 <     (not Force) then
812 <    IBDataBaseError
813 <  else
814 <  begin
815 <    FHandle := nil;
816 <    FHandleIsShared := False;
817 <  end;
751 >  FAttachment.Disconnect(Force);
752 >  FAttachment := nil;
753  
754    if not (csDesigning in ComponentState) then
755      MonitorHook.DBDisconnect(Self);
# Line 824 | Line 759 | begin
759        SQLObjects[i].DoAfterDatabaseDisconnect;
760   end;
761  
827 procedure TIBDataBase.LoadCharSetInfo;
828 var Query: TIBSQL;
829    i: integer;
830 begin
831  if not FInternalTransaction.Active then
832    FInternalTransaction.StartTransaction;
833  Query := TIBSQL.Create(self);
834  try
835    Query.Database := Self;
836    Query.Transaction := FInternalTransaction;
837    Query.SQL.Text := 'Select RDB$CHARACTER_SET_ID, RDB$BYTES_PER_CHARACTER ' +
838                      'From RDB$CHARACTER_SETS Order by 1 DESC'; {do not localize}
839    Query.Prepare;
840    Query.ExecQuery;
841    if not Query.EOF then
842    begin
843      SetLength(FCharSetSizes,Query.FieldByName('RDB$CHARACTER_SET_ID').AsInteger + 1);
844      for i := 0 to Length(FCharSetSizes) - 1 do FCharSetSizes[i] := 1;
845      repeat
846        FCharSetSizes[Query.FieldByName('RDB$CHARACTER_SET_ID').AsInteger] :=
847                 Query.FieldByName('RDB$BYTES_PER_CHARACTER').AsInteger;
848        Query.Next;
849      until Query.EOF;
850    end;
851  finally
852    Query.free;
853    FInternalTransaction.Commit;
854  end;
855 end;
856
762   procedure TIBDataBase.CheckStreamConnect;
763   var
764    i: integer;
# Line 876 | Line 781 | begin
781           (FDefaultTransaction.FStreamedActive) and
782           (not FDefaultTransaction.InTransaction) then
783          FDefaultTransaction.StartTransaction;
784 <      FStreamedConnected := False;
784 >      StreamedConnected := False;
785      end;
786    except
787      if csDesigning in ComponentState then
# Line 917 | Line 822 | begin
822    end;
823   end;
824  
825 < function TIBDataBase.Login: Boolean;
825 > function TIBDataBase.Login(var aDatabaseName: string): Boolean;
826   var
827    IndexOfUser, IndexOfPassword: Integer;
828    Username, Password, OldPassword: String;
# Line 953 | Line 858 | begin
858        LoginParams.Assign(Params);
859        FOnLogin(Self, LoginParams);
860        Params.Assign (LoginParams);
861 +      aDatabaseName := FDBName;
862        HidePassword;
863      finally
864        LoginParams.Free;
# Line 974 | Line 880 | begin
880                                           Length(Params[IndexOfPassword]));
881        OldPassword := password;
882      end;
883 <    result := IBGUIInterface.LoginDialogEx(DatabaseName, Username, Password, False);
883 >
884 >    result := IBGUIInterface.LoginDialogEx(aDatabaseName, Username, Password, False);
885      if result then
886      begin
887 <      if IndexOfUser = -1 then
888 <        Params.Add(DPBConstantNames[isc_dpb_user_name] + '=' + Username)
889 <      else
890 <        Params[IndexOfUser] := DPBConstantNames[isc_dpb_user_name] +
887 >      if Username <> '' then
888 >      begin
889 >        if IndexOfUser = -1 then
890 >          Params.Add(DPBConstantNames[isc_dpb_user_name] + '=' + Username)
891 >        else
892 >          Params[IndexOfUser] := DPBConstantNames[isc_dpb_user_name] +
893                                   '=' + Username;
894 +      end
895 +      else
896 +      if IndexOfUser <> -1 then
897 +        Params.Delete(IndexOfUser);
898        if (Password = OldPassword) then
899          FHiddenPassword := ''
900        else
# Line 1002 | Line 915 | end;
915  
916   procedure TIBDataBase.DoConnect;
917   var
1005  DPB: String;
918    TempDBParams: TStrings;
919    I: integer;
920    aDBName: string;
921 +  Status: IStatus;
922 +  CharSetID: integer;
923   begin
924    CheckInactive;
925    CheckDatabaseName;
# Line 1015 | Line 929 | begin
929      FDBParamsChanged := True;
930    end;
931    { Use builtin login prompt if requested }
932 <  if (LoginPrompt or (csDesigning in ComponentState)) and not Login then
932 >  aDBName := FDBName;
933 >  if (LoginPrompt or (csDesigning in ComponentState)) and not Login(aDBName) then
934      IBError(ibxeOperationCancelled, [nil]);
935  
936    TempDBParams := TStringList.Create;
937    try
938     TempDBParams.Assign(FDBParams);
939 <   aDBName := FDBName;
940 <   {Opportuning to override defaults}
939 >   if UseDefaultSystemCodePage then
940 >   begin
941 >     {$ifdef WINDOWS}
942 >     if FirebirdAPI.CodePage2CharSetID(GetACP,CharSetID) then
943 >       TempDBParams.Values['lc_ctype'] := FirebirdAPI.GetCharsetName(CharSetID)
944 >     {$else}
945 >     if FirebirdAPI.CodePage2CharSetID(DefaultSystemCodePage,CharSetID) then
946 >       TempDBParams.Values['lc_ctype'] := FirebirdAPI.GetCharsetName(CharSetID)
947 >     {$endif}
948 >     else
949 >       TempDBParams.Values['lc_ctype'] :='UTF8';
950 >   end;
951 >   {Opportunity to override defaults}
952     for i := 0 to FSQLObjects.Count - 1 do
953     begin
954         if FSQLObjects[i] <> nil then
955           SQLObjects[i].DoBeforeDatabaseConnect(TempDBParams,aDBName);
956     end;
957  
958 +   FDefaultCharSetName := AnsiUpperCase(TempDBParams.Values['lc_ctype']);
959 +   if FDefaultCharSetName <> '' then
960 +     FirebirdAPI.CharSetName2CharSetID(FDefaultCharSetName,FDefaultCharSetID);
961 +   FirebirdAPI.CharSetID2CodePage(FDefaultCharSetID,FDefaultCodePage);
962     { Generate a new DPB if necessary }
963     if (FDBParamsChanged or (TempDBParams.Text <> FDBParams.Text)) then
964     begin
965       FDBParamsChanged := False;
966       if (not LoginPrompt and not (csDesigning in ComponentState)) or (FHiddenPassword = '') then
967 <       GenerateDPB(TempDBParams, DPB, FDPBLength)
967 >       FDPB := GenerateDPB(TempDBParams)
968       else
969       begin
970          TempDBParams.Add('password=' + FHiddenPassword);
971 <        GenerateDPB(TempDBParams, DPB, FDPBLength);
971 >        FDPB := GenerateDPB(TempDBParams);
972       end;
1043     IBAlloc(FDPB, 0, FDPBLength);
1044     Move(DPB[1], FDPB[0], FDPBLength);
973     end;
974    finally
975     TempDBParams.Free;
976    end;
977 <  if Call(isc_attach_database(StatusVector, Length(aDBName),
978 <                         PChar(aDBName), @FHandle,
979 <                         FDPBLength, FDPB), False) > 0 then
980 <  begin
981 <    FHandle := nil;
982 <    IBDataBaseError;
983 <  end;
977 >
978 >  repeat
979 >    if FCreateDatabase then
980 >    begin
981 >      FCreateDatabase := false;
982 >      FAttachment := FirebirdAPI.CreateDatabase(aDBName,FDPB, false);
983 >      if assigned(FOnCreateDatabase) and (FAttachment <> nil) then
984 >        OnCreateDatabase(self);
985 >    end
986 >    else
987 >      FAttachment := FirebirdAPI.OpenDatabase(aDBName,FDPB,false);
988 >    if FAttachment = nil then
989 >    begin
990 >      Status := FirebirdAPI.GetStatus;
991 >      {$IFDEF UNIX}
992 >      if Pos(':',aDBName) = 0 then
993 >      begin
994 >          if ((Status.GetSQLCode = -901) and (Status.GetIBErrorCode = isc_random)) {Access permissions on firebird temp}
995 >             or
996 >             ((Status.GetSQLCode = -902) and (Status.GetIBErrorCode = isc_sys_request)) {Security DB Problem}
997 >             or
998 >             ((Status.GetSQLCode = -902) and (Status.GetIBErrorCode = isc_psw_attach)) {Security DB Problem}
999 >             or
1000 >             ((Status.GetSQLCode = -904) and (Status.GetIBErrorCode = isc_lock_dir_access)) {Lock File Problem}
1001 >             then
1002 >             begin
1003 >               aDBName := 'localhost:' + aDBName;
1004 >               Continue;
1005 >            end
1006 >      end;
1007 >      {$ENDIF}
1008 >      if ((Status.GetSQLCode = -902) and (Status.GetIBErrorCode = isc_io_error)) {Database not found}
1009 >                       and CreateIfNotExists and not (csDesigning in ComponentState) then
1010 >        FCreateDatabase := true
1011 >      else
1012 >        raise EIBInterBaseError.Create(Status);
1013 >    end;
1014 >  until FAttachment <> nil;
1015    if not (csDesigning in ComponentState) then
1016      FDBName := aDBName; {Synchronise at run time}
1017    FDBSQLDialect := GetDBSQLDialect;
# Line 1064 | Line 1023 | begin
1023    end;
1024    if not (csDesigning in ComponentState) then
1025      MonitorHook.DBConnect(Self);
1067  LoadCharSetInfo;
1026   end;
1027  
1028   procedure TIBDataBase.RemoveSQLObject(Idx: Integer);
# Line 1167 | Line 1125 | begin
1125    FDefaultTransaction := Value;
1126   end;
1127  
1170 procedure TIBDataBase.SetHandle(Value: TISC_DB_HANDLE);
1171 begin
1172  if HandleIsShared then
1173    Close
1174  else
1175    CheckInactive;
1176  FHandle := Value;
1177  FHandleIsShared := (Value <> nil);
1178 end;
1179
1128   procedure TIBDataBase.SetIdleTimer(Value: Integer);
1129   begin
1130    if Value < 0 then
# Line 1221 | Line 1169 | end;
1169   begin
1170    if Connected then
1171    begin
1172 <    if FCanTimeout then
1172 >    if not FAttachment.HasActivity then
1173      begin
1174        ForceClose;
1175        if Assigned(FOnIdleTimer) then
1176          FOnIdleTimer(Self);
1177      end
1230    else
1231      FCanTimeout := True;
1178    end;
1179   end;
1180  
# Line 1259 | Line 1205 | end;
1205   procedure TIBDataBase.SetSQLDialect( const Value: Integer);
1206   begin
1207    if (Value < 1) then IBError(ibxeSQLDialectInvalid, [nil]);
1208 <  if ((FHandle = nil) or (Value <= FDBSQLDialect))  then
1208 >  if ((FAttachment = nil) or (Value <= FDBSQLDialect))  then
1209      FSQLDialect := Value
1210    else
1211      IBError(ibxeSQLDialectInvalid, [nil]);
# Line 1378 | Line 1324 | begin
1324        BeginUpdate;
1325        try
1326          Clear;
1327 <        while (not Query.EOF) and (Query.Next <> nil) do
1328 <          List.Add(TrimRight(Query.Current.ByName('RDB$FIELD_NAME').AsString)); {do not localize}
1327 >        while (not Query.EOF) and Query.Next  do
1328 >          List.Add(TrimRight(Query.FieldByName('RDB$FIELD_NAME').AsString)); {do not localize}
1329        finally
1330          EndUpdate;
1331        end;
# Line 1418 | Line 1364 | begin
1364          BeginUpdate;
1365          try
1366            Clear;
1367 <          while (not Query.EOF) and (Query.Next <> nil) do
1368 <            List.Add(TrimRight(Query.Current[0].AsString));
1367 >          while (not Query.EOF) and Query.Next  do
1368 >            List.Add(TrimRight(Query.Fields[0].AsString));
1369          finally
1370            EndUpdate;
1371          end;
# Line 1436 | Line 1382 | end;
1382   constructor TIBTransaction.Create(AOwner: TComponent);
1383   begin
1384    inherited Create(AOwner);
1439  FIBLoaded := False;
1440  CheckIBLoaded;
1441  FIBLoaded := True;
1442  CheckIBLoaded;
1385    FDatabases := TList.Create;
1386    FSQLObjects := TList.Create;
1445  FHandle := nil;
1387    FTPB := nil;
1447  FTPBLength := 0;
1388    FTRParams := TStringList.Create;
1389    FTRParamsChanged := True;
1390    TStringList(FTRParams).OnChange := TRParamsChange;
# Line 1460 | Line 1400 | destructor TIBTransaction.Destroy;
1400   var
1401    i: Integer;
1402   begin
1403 <  if FIBLoaded then
1404 <  begin
1405 <    if InTransaction then
1406 <      EndTransaction(FDefaultAction, True);
1407 <    for i := 0 to FSQLObjects.Count - 1 do
1408 <      if FSQLObjects[i] <> nil then
1409 <        SQLObjects[i].DoTransactionFree;
1410 <    RemoveSQLObjects;
1411 <    RemoveDatabases;
1412 <    FreeMem(FTPB);
1413 <    FTPB := nil;
1474 <    FTRParams.Free;
1475 <    FSQLObjects.Free;
1476 <    FDatabases.Free;
1477 <  end;
1403 >  if InTransaction then
1404 >    EndTransaction(FDefaultAction, True);
1405 >  for i := 0 to FSQLObjects.Count - 1 do
1406 >    if FSQLObjects[i] <> nil then
1407 >      SQLObjects[i].DoTransactionFree;
1408 >  RemoveSQLObjects;
1409 >  RemoveDatabases;
1410 >  FTPB := nil;
1411 >  FTRParams.Free;
1412 >  FSQLObjects.Free;
1413 >  FDatabases.Free;
1414    inherited Destroy;
1415   end;
1416  
1481 function TIBTransaction.Call(ErrCode: ISC_STATUS;
1482  RaiseError: Boolean): ISC_STATUS;
1483 var
1484  i: Integer;
1485 begin
1486  result := ErrCode;
1487  for i := 0 to FDatabases.Count - 1 do if FDatabases[i] <> nil then
1488    Databases[i].FCanTimeout := False;
1489  FCanTimeout := False;
1490  if RaiseError and (result > 0) then
1491    IBDataBaseError;
1492 end;
1493
1417   procedure TIBTransaction.CheckDatabasesInList;
1418   begin
1419    if GetDatabaseCount = 0 then
# Line 1501 | Line 1424 | procedure TIBTransaction.CheckInTransact
1424   begin
1425    if FStreamedActive and (not InTransaction) then
1426      Loaded;
1427 <  if (FHandle = nil) then
1427 >  if (TransactionIntf = nil) then
1428      IBError(ibxeNotInTransaction, [nil]);
1429   end;
1430  
# Line 1557 | Line 1480 | procedure TIBTransaction.EnsureNotInTran
1480   begin
1481    if csDesigning in ComponentState then
1482    begin
1483 <    if FHandle <> nil then
1483 >    if TransactionIntf <> nil then
1484        Rollback;
1485    end;
1486   end;
1487  
1488   procedure TIBTransaction.CheckNotInTransaction;
1489   begin
1490 <  if (FHandle <> nil) then
1490 >  if (TransactionIntf <> nil) and  TransactionIntf.InTransaction then
1491      IBError(ibxeInTransaction, [nil]);
1492   end;
1493  
# Line 1573 | Line 1496 | var
1496    i: Integer;
1497    NilFound: Boolean;
1498   begin
1499 +  EnsureNotInTransaction;
1500 +  CheckNotInTransaction;
1501 +  FTransactionIntf := nil;
1502 +
1503    i := FindDatabase(db);
1504    if i <> -1 then
1505    begin
# Line 1623 | Line 1550 | end;
1550   procedure TIBTransaction.EndTransaction(Action: TTransactionAction;
1551    Force: Boolean);
1552   var
1626  status: ISC_STATUS;
1553    i: Integer;
1554   begin
1555    CheckInTransaction;
# Line 1634 | Line 1560 | begin
1560    case Action of
1561      TARollback, TACommit:
1562      begin
1637      if (HandleIsShared) and
1638         (Action <> FDefaultAction) and
1639         (not Force) then
1640        IBError(ibxeCantEndSharedTransaction, [nil]);
1563        DoBeforeTransactionEnd;
1564        for i := 0 to FSQLObjects.Count - 1 do if FSQLObjects[i] <> nil then
1565          SQLObjects[i].DoBeforeTransactionEnd(Action);
1566        if InTransaction then
1567        begin
1568 <        if HandleIsShared then
1569 <        begin
1648 <          FHandle := nil;
1649 <          FHandleIsShared := False;
1650 <          status := 0;
1651 <        end
1568 >        if (Action = TARollback) then
1569 >            FTransactionIntf.Rollback(Force)
1570          else
1571 <          if (Action = TARollback) then
1572 <            status := Call(isc_rollback_transaction(StatusVector, @FHandle), False)
1573 <          else
1574 <            status := Call(isc_commit_transaction(StatusVector, @FHandle), False);
1575 <        if ((Force) and (status > 0)) then
1576 <          status := Call(isc_rollback_transaction(StatusVector, @FHandle), False);
1577 <        if Force then
1578 <          FHandle := nil
1579 <        else
1580 <          if (status > 0) then
1581 <            IBDataBaseError;
1571 >        try
1572 >          FTransactionIntf.Commit;
1573 >        except on E: EIBInterBaseError do
1574 >          begin
1575 >            if Force then
1576 >              FTransactionIntf.Rollback(Force)
1577 >            else
1578 >              raise;
1579 >          end;
1580 >        end;
1581 >
1582          for i := 0 to FSQLObjects.Count - 1 do if FSQLObjects[i] <> nil then
1583            SQLObjects[i].DoAfterTransactionEnd;
1584          DoAfterTransactionEnd;
1585        end;
1586      end;
1587      TACommitRetaining:
1588 <      Call(isc_commit_retaining(StatusVector, @FHandle), True);
1588 >      FTransactionIntf.CommitRetaining;
1589 >
1590      TARollbackRetaining:
1591 <      Call(isc_rollback_retaining(StatusVector, @FHandle), True);
1591 >      FTransactionIntf.RollbackRetaining;
1592    end;
1593    if not (csDesigning in ComponentState) then
1594    begin
# Line 1721 | Line 1640 | end;
1640  
1641   function TIBTransaction.GetInTransaction: Boolean;
1642   begin
1643 <  result := (FHandle <> nil);
1643 >  result := (TransactionIntf <> nil) and TransactionIntf.InTransaction;
1644   end;
1645  
1646   function TIBTransaction.FindDatabase(db: TIBDatabase): Integer;
# Line 1777 | Line 1696 | procedure TIBTransaction.BeforeDatabaseD
1696   begin
1697    if InTransaction then
1698      EndTransaction(FDefaultAction, True);
1699 +  FTransactionIntf := nil;
1700   end;
1701  
1702   procedure TIBTransaction.RemoveDatabase(Idx: Integer);
# Line 1785 | Line 1705 | var
1705   begin
1706    if ((Idx >= 0) and (FDatabases[Idx] <> nil)) then
1707    begin
1708 +    EnsureNotInTransaction;
1709 +    CheckNotInTransaction;
1710 +    FTransactionIntf := nil;
1711 +
1712      DB := Databases[Idx];
1713      FDatabases[Idx] := nil;
1714      DB.RemoveTransaction(DB.FindTransaction(Self));
# Line 1797 | Line 1721 | procedure TIBTransaction.RemoveDatabases
1721   var
1722    i: Integer;
1723   begin
1724 +  EnsureNotInTransaction;
1725 +  CheckNotInTransaction;
1726 +  FTransactionIntf := nil;
1727 +
1728    for i := 0 to FDatabases.Count - 1 do if FDatabases[i] <> nil then
1729      RemoveDatabase(i);
1730   end;
# Line 1843 | Line 1771 | begin
1771          Rollback;
1772   end;
1773  
1846 procedure TIBTransaction.SetDefaultAction(Value: TTransactionAction);
1847 begin
1848 (*  if (Value = taRollbackRetaining) and (GetIBClientVersion < 6) then
1849    IBError(ibxeIB60feature, [nil]);*)
1850  FDefaultAction := Value;
1851 end;
1852
1774   procedure TIBTransaction.SetDefaultDatabase(Value: TIBDatabase);
1775   var
1776    i: integer;
# Line 1872 | Line 1793 | begin
1793    FDefaultDatabase := Value;
1794   end;
1795  
1875 procedure TIBTransaction.SetHandle(Value: TISC_TR_HANDLE);
1876 begin
1877  if (HandleIsShared) then
1878    EndTransaction(DefaultAction, True)
1879  else
1880    CheckNotInTransaction;
1881  FHandle := Value;
1882  FHandleIsShared := (Value <> nil);
1883 end;
1884
1796   procedure TIBTransaction.Notification( AComponent: TComponent;
1797                                          Operation: TOperation);
1798   var
# Line 1923 | Line 1834 | end;
1834  
1835   procedure TIBTransaction.StartTransaction;
1836   var
1926  pteb: PISC_TEB_ARRAY;
1927  TPB: String;
1837    i: Integer;
1838 +  Attachments: array of IAttachment;
1839 +  ValidDatabaseCount: integer;
1840   begin
1841    CheckNotInTransaction;
1842    CheckDatabasesInList;
1843 +  if TransactionIntf <> nil then
1844 +  begin
1845 +    TransactionIntf.Start(DefaultAction);
1846 +    Exit;
1847 +  end;
1848 +
1849    for i := 0 to FDatabases.Count - 1 do
1850     if  FDatabases[i] <> nil then
1851     begin
1852       with TIBDatabase(FDatabases[i]) do
1853       if not Connected then
1854 <       if FStreamedConnected then
1854 >       if StreamedConnected then
1855         begin
1856           Open;
1857 <         FStreamedConnected := False;
1857 >         StreamedConnected := False;
1858         end
1859         else
1860           IBError(ibxeDatabaseClosed, [nil]);
# Line 1945 | Line 1862 | begin
1862    if FTRParamsChanged then
1863    begin
1864      FTRParamsChanged := False;
1865 <    GenerateTPB(FTRParams, TPB, FTPBLength);
1949 <    if FTPBLength > 0 then
1950 <    begin
1951 <      IBAlloc(FTPB, 0, FTPBLength);
1952 <      Move(TPB[1], FTPB[0], FTPBLength);
1953 <    end;
1865 >    FTPB :=  GenerateTPB(FTRParams);
1866    end;
1867  
1868 <  pteb := nil;
1869 <  IBAlloc(pteb, 0, DatabaseCount * SizeOf(TISC_TEB));
1870 <  try
1871 <    for i := 0 to DatabaseCount - 1 do if Databases[i] <> nil then
1872 <    begin
1873 <      pteb^[i].db_handle := @(Databases[i].Handle);
1874 <      pteb^[i].tpb_length := FTPBLength;
1875 <      pteb^[i].tpb_address := FTPB;
1876 <    end;
1877 <    if Call(isc_start_multiple(StatusVector, @FHandle,
1878 <                               DatabaseCount, PISC_TEB(pteb)), False) > 0 then
1879 <    begin
1880 <      FHandle := nil;
1881 <      IBDataBaseError;
1970 <    end;
1971 <    if not (csDesigning in ComponentState) then
1972 <      MonitorHook.TRStart(Self);
1973 <  finally
1974 <    FreeMem(pteb);
1868 >  ValidDatabaseCount := 0;
1869 >  for i := 0 to DatabaseCount - 1 do
1870 >    if Databases[i] <> nil then Inc(ValidDatabaseCount);
1871 >
1872 >  if ValidDatabaseCount = 1 then
1873 >    FTransactionIntf := Databases[0].Attachment.StartTransaction(FTPB,DefaultAction)
1874 >  else
1875 >  begin
1876 >    SetLength(Attachments,ValidDatabaseCount);
1877 >    for i := 0 to DatabaseCount - 1 do
1878 >      if Databases[i] <> nil then
1879 >        Attachments[i] := Databases[i].Attachment;
1880 >
1881 >    FTransactionIntf := FirebirdAPI.StartTransaction(Attachments,FTPB,DefaultAction);
1882    end;
1883 +
1884 +  if not (csDesigning in ComponentState) then
1885 +      MonitorHook.TRStart(Self);
1886    DoOnStartTransaction;
1887   end;
1888  
# Line 1980 | Line 1890 | procedure TIBTransaction.TimeoutTransact
1890   begin
1891    if InTransaction then
1892    begin
1893 <    if FCanTimeout then
1893 >    if not TransactionIntf.HasActivity then
1894      begin
1895        EndTransaction(FDefaultAction, True);
1896        if Assigned(FOnIdleTimer) then
1897          FOnIdleTimer(Self);
1898      end
1989    else
1990      FCanTimeout := True;
1899    end;
1900   end;
1901  
# Line 2000 | Line 1908 | procedure TIBTransaction.TRParamsChangin
1908   begin
1909    EnsureNotInTransaction;
1910    CheckNotInTransaction;
1911 +  FTransactionIntf := nil;
1912   end;
1913  
1914   { TIBBase }
# Line 2015 | Line 1924 | begin
1924    inherited Destroy;
1925   end;
1926  
2018 function TIBBase.GetCharSetSize(CharSetID: integer): integer;
2019 begin
2020  if (CharSetID >= 0) and (CharSetID < Length(Database.FCharSetSizes)) then
2021    Result := Database.FCharSetSizes[CharSetID]
2022  else
2023    Result := 1; {Unknown character set}
2024 end;
2025
1927   procedure TIBBase.HandleException(Sender: TObject);
1928   begin
1929    if assigned(Database) then
# Line 2061 | Line 1962 | begin
1962    FTransaction.CheckInTransaction;
1963   end;
1964  
2064 function TIBBase.GetDBHandle: PISC_DB_HANDLE;
2065 begin
2066  CheckDatabase;
2067  result := @FDatabase.Handle;
2068 end;
2069
2070 function TIBBase.GetTRHandle: PISC_TR_HANDLE;
2071 begin
2072  CheckTransaction;
2073  result := @FTransaction.Handle;
2074 end;
2075
1965   procedure TIBBase.DoBeforeDatabaseConnect(DBParams: TStrings; var DBName: string
1966    );
1967   begin
# Line 2187 | Line 2076 | end;
2076    parameter buffer, and return it and its length
2077    in DPB and DPBLength, respectively. }
2078  
2079 < procedure GenerateDPB(sl: TStrings; var DPB: string; var DPBLength: Short);
2079 > function GenerateDPB(sl: TStrings): IDPB;
2080   var
2081 <  i, j, pval: Integer;
2081 >  i, j: Integer;
2082    DPBVal: UShort;
2083    ParamName, ParamValue: string;
2084   begin
2085 <  { The DPB is initially empty, with the exception that
2197 <    the DPB version must be the first byte of the string. }
2198 <  DPBLength := 1;
2199 <  DPB := Char(isc_dpb_version1);
2085 >  Result := FirebirdAPI.AllocateDPB;
2086  
2087    {Iterate through the textual database parameters, constructing
2088     a DPB on-the-fly }
# Line 2235 | Line 2121 | begin
2121        begin
2122          if DPBVal = isc_dpb_sql_dialect then
2123            ParamValue[1] := Char(Ord(ParamValue[1]) - 48);
2124 <        DPB := DPB +
2239 <               Char(DPBVal) +
2240 <               Char(Length(ParamValue)) +
2241 <               ParamValue;
2242 <        Inc(DPBLength, 2 + Length(ParamValue));
2124 >        Result.Add(DPBVal).SetAsString(ParamValue);
2125        end;
2126 +
2127        isc_dpb_num_buffers, isc_dpb_dbkey_scope, isc_dpb_force_write,
2128        isc_dpb_no_reserve, isc_dpb_damaged, isc_dpb_verify:
2129 <      begin
2130 <        DPB := DPB +
2248 <               Char(DPBVal) +
2249 <               #1 +
2250 <               Char(StrToInt(ParamValue));
2251 <        Inc(DPBLength, 3);
2252 <      end;
2129 >        Result.Add(DPBVal).SetAsByte(byte(ParamValue[1]));
2130 >
2131        isc_dpb_sweep:
2132 <      begin
2133 <        DPB := DPB +
2256 <               Char(DPBVal) +
2257 <               #1 +
2258 <               Char(isc_dpb_records);
2259 <        Inc(DPBLength, 3);
2260 <      end;
2132 >        Result.Add(DPBVal).SetAsByte(isc_dpb_records);
2133 >
2134        isc_dpb_sweep_interval:
2135 <      begin
2136 <        pval := StrToInt(ParamValue);
2264 <        DPB := DPB +
2265 <               Char(DPBVal) +
2266 <               #4 +
2267 <               PChar(@pval)[0] +
2268 <               PChar(@pval)[1] +
2269 <               PChar(@pval)[2] +
2270 <               PChar(@pval)[3];
2271 <        Inc(DPBLength, 6);
2272 <      end;
2135 >        Result.Add(DPBVal).SetAsInteger(StrToInt(ParamValue));
2136 >
2137        isc_dpb_activate_shadow, isc_dpb_delete_shadow, isc_dpb_begin_log,
2138        isc_dpb_quit_log:
2139 <      begin
2276 <        DPB := DPB +
2277 <               Char(DPBVal) +
2278 <               #1 + #0;
2279 <        Inc(DPBLength, 3);
2280 <      end;
2139 >        Result.Add(DPBVal).SetAsByte(0);
2140        else
2141        begin
2142          if (DPBVal > 0) and
# Line 2295 | Line 2154 | end;
2154    of the transaction parameters, generate a transaction
2155    parameter buffer, and return it and its length in
2156    TPB and TPBLength, respectively. }
2157 < procedure GenerateTPB(sl: TStrings; var TPB: string; var TPBLength: Short);
2157 > function GenerateTPB(sl: TStrings): ITPB;
2158   var
2159 <  i, j, TPBVal, ParamLength: Integer;
2159 >  i, j, TPBVal: Integer;
2160    ParamName, ParamValue: string;
2161   begin
2162 <  TPB := '';
2304 <  if (sl.Count = 0) then
2305 <    TPBLength := 0
2306 <  else
2307 <  begin
2308 <    TPBLength := sl.Count + 1;
2309 <    TPB := TPB + Char(isc_tpb_version3);
2310 <  end;
2162 >  Result := FirebirdAPI.AllocateTPB;
2163    for i := 0 to sl.Count - 1 do
2164    begin
2165      if (Trim(sl[i]) =  '') then
2314    begin
2315      Dec(TPBLength);
2166        Continue;
2167 <    end;
2167 >
2168      if (Pos('=', sl[i]) = 0) then {mbcs ok}
2169        ParamName := LowerCase(sl[i]) {mbcs ok}
2170      else
# Line 2338 | Line 2188 | begin
2188        isc_tpb_concurrency, isc_tpb_shared, isc_tpb_wait, isc_tpb_nowait,
2189        isc_tpb_read, isc_tpb_write, isc_tpb_ignore_limbo,
2190        isc_tpb_read_committed, isc_tpb_rec_version, isc_tpb_no_rec_version:
2191 <        TPB := TPB + Char(TPBVal);
2191 >        Result.Add(TPBVal);
2192 >
2193        isc_tpb_lock_read, isc_tpb_lock_write:
2194 <      begin
2195 <        TPB := TPB + Char(TPBVal);
2345 <        { Now set the string parameter }
2346 <        ParamLength := Length(ParamValue);
2347 <        Inc(TPBLength, ParamLength + 1);
2348 <        TPB := TPB + Char(ParamLength) + ParamValue;
2349 <      end;
2194 >        Result.Add(TPBVal).SetAsString(ParamValue);
2195 >
2196        else
2197        begin
2198          if (TPBVal > 0) and

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines